Skip to content

Conversation

@proeseler
Copy link
Contributor

Summary

This pull request introduces the QBayesian class to the Qiskit Machine Learning library. The class implements the Quantum Bayesian Inference algorithm, providing a quantum-based approach to infer probabilities in Bayesian networks. This enhancement aligns with the ongoing efforts to expand the library's capabilities in quantum machine learning algorithms. The algorithm is based on the paper from Low, Guang Hao, Theodore J. Yoder, and Isaac L. Chuang. "Quantum inference on Bayesian networks", Physical Review A 89.6 (2014): 062315.

Details and comments

  • Added QBayesian class in qiskit_machine_learning/algorithms/inference.
  • Included unit tests for the new class in tests/algorithms/inference.
  • Updated documentation to reflect the addition of QBayesian and included a tutorial in docs.

✅ I have added the tests to cover my changes.
✅ I have updated the documentation accordingly.
✅ I have read the CONTRIBUTING document.

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@declanmillar declanmillar self-requested a review February 29, 2024 15:51
Copy link
Contributor

@declanmillar declanmillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for introducing this exciting feature! I've made a few surface-level suggestions, but I need to go through the method and tutorial in more detail to check my understanding of the implementation.

adekusar-drl
adekusar-drl previously approved these changes Mar 1, 2024
…b7e0.yaml

Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
Copy link
Collaborator

@edoaltamura edoaltamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to re-run CI tests with the most up-to-date dev branch just before merging. Looking forward to having Bayesian methods in the codebase!

@proeseler
Copy link
Contributor Author

I'm not even sure I can, but should I merge it or do you?

@edoaltamura
Copy link
Collaborator

I would be happy to go ahead, but I would like to hear the opinions of @woodsp-ibm and @OkuyanBoga. Do you think this is a good time to merge?

@woodsp-ibm
Copy link
Member

Do you think this is a good time to merge?

It seems fine to me given the expectation that this feature will be in the next main release.

@OkuyanBoga OkuyanBoga merged commit 91473a2 into qiskit-community:main May 20, 2024
@OkuyanBoga
Copy link
Collaborator

Thank you all, I merged it after the approvals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants