Fix CI for data provider change and cct draw #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsp-ibm
requested review from
stefan-woerner and
t-imamichi
as code owners
t-imamichi
approved these changes
Sep 13, 2024
|
It seems that one of the notebooks, which was failing before also with the bug introduced in Qiskit 1.2.0, ie. the _gates_to_uncompute method not being found, is now failing with a dead kernel. So I guess I'll have to take a look at that too. |
|
Having checked out the notebook failure it seems that its using Qiskit Aer and its Sampler and switching it to the Qiskit Sampler it works fine. I raised an issue on Aer that I linked in an issue here #345 to track things. Since this PR fixes the other problems rather than waiting for a fix (I had already been waiting sometime for the gates to uncompute fix to come out) I am going to merge this as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #343
Now that the Qiskit issue referenced in #343 has been released in 1.2.1 I have updated the failing data provider test reference values and also fixed the reference circuit draw output since that has changed too.
Details and comments