Skip Nasdaq Data Link test if token not provided #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoelmarques
requested review from
stefan-woerner and
woodsp-ibm
as code owners
Pull Request Test Coverage Report for Build 2949884543
💛 - Coveralls |
woodsp-ibm
approved these changes
Aug 29, 2022
manoelmarques
added
the
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2022
(cherry picked from commit 71c190c) # Conflicts: # qiskit_finance/data_providers/exchange_data_provider.py # qiskit_finance/data_providers/wikipedia_data_provider.py # test/circuit/test_european_call_delta_objective.py # test/circuit/test_european_call_pricing_objective.py # test/circuit/test_fixed_income_pricing_objective.py # test/data_providers/test_data_providers.py
manoelmarques
added a commit
that referenced
this pull request
Aug 29, 2022
(cherry picked from commit 71c190c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #198
The Nasdaq Data Link tests will be skipped if token is not provided in an env.variable. Since a token is personal and not provided in the CI, the CI will always skip those tests. In case a token is provided, any error will fail the unit test.
For Wikipedia provider a token is not mandatory. In that case, any error will fail unit test unless it is a daily data usage exceeded in which case it will be skipped.
Details and comments