Skip to content

Improve custom equals fns #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Conversation

woodsp-ibm
Copy link
Member

Summary

In #225 I introduced a couple of custom equals functions. These were also added to ML in qiskit-community/qiskit-machine-learning#836 as the optimizers are locally copied there now. ML still runs mypy and it flagged issues with the equals implementation that this update addresses.

Details and comments

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13954979262

Details

  • 4 of 6 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 90.454%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_algorithms/optimizers/gradient_descent.py 2 3 66.67%
qiskit_algorithms/optimizers/steppable_optimizer.py 2 3 66.67%
Totals Coverage Status
Change from base Build 13951776291: -0.02%
Covered Lines: 6396
Relevant Lines: 7071

💛 - Coveralls

Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT merged commit 7570295 into qiskit-community:main Mar 26, 2025
16 of 18 checks passed
@woodsp-ibm woodsp-ibm deleted the improve_eq branch March 26, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants