resume upload part concurrently #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihsai0
force-pushed
the
feat/resume-upload-part-concurrently
branch
from
5f0dbd1 to
111422a
Compare
bachue
reviewed
Sep 25, 2023
| ---------- | ||
| up_token: str | ||
| kwargs | ||
| key, file_crc32, costume_vars, metadata |
There was a problem hiding this comment.
@lihsai0 file_crc32 => crc32
bachue
reviewed
Sep 25, 2023
| file_name: str | ||
| costume_vars: dict | ||
| kwargs | ||
| up_token, file_crc32 |
There was a problem hiding this comment.
@lihsai0 file_crc32 => crc32
There was a problem hiding this comment.
标准库和 utils 里都有 crc32 这个名字，感觉容易混淆。
There was a problem hiding this comment.
file_crc32 => crc32_int
bachue
reviewed
Sep 25, 2023
| mime_type: str | ||
| metadata: dict | ||
| file_name: str | ||
| costume_vars: dict |
bachue
reviewed
Sep 25, 2023
| _ResumeUploadV2Context | ||
| """ | ||
| if not isinstance(context, _ResumeUploadV2Context): | ||
| raise TypeError('context must be an instance of _ResumeUploadV1Context') |
There was a problem hiding this comment.
@lihsai0 _ResumeUploadV1Context => _ResumeUploadV2Context
bachue
reviewed
Sep 25, 2023
qiniu/compat.py
Outdated
| @@ -51,6 +51,13 @@ def s(data): | |||
| def u(data): | |||
| return unicode(data, 'unicode_escape') # noqa | |||
|
|
|||
| def is_seekable(data): | |||
| try: | |||
| data.seek(0, 1) | |||
lihsai0
commented
Sep 25, 2023
|
|
||
| Returns | ||
| ------- | ||
| ret: dict |
There was a problem hiding this comment.
dict => _ResumeUploadV2Context
bachue
approved these changes
Sep 25, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #440 +/- ##
==========================================
- Coverage 76.06% 70.04% -6.02%
==========================================
Files 26 35 +9
Lines 2452 3108 +656
==========================================
+ Hits 1865 2177 +312
- Misses 587 931 +344
|
bachue
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KODO-18759