Refactor some code & add some test cases #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helloyou2012
changed the title
JemyCheung
reviewed
Oct 18, 2019
test/rs.test.js
Outdated
| it('test privateDownloadUrl', function (done) { | ||
| var key = 'qiniu.mp4'; | ||
| var url = bucketManager.privateDownloadUrl('http://' + domain, key, 20); | ||
| should.equal(url, 'http://' + domain + '/qiniu.mp4?e=20&token=ExAdnmHq914NVa8addkXooUvXSyzGPHYzxzJwDnN:vZRvLfuw4U9vJzweTVgPdPFIY-g='); |
| should.not.exist(err); | ||
| console.log(JSON.stringify(respBody) + '\n'); | ||
| console.log(JSON.stringify(respInfo)); | ||
| respBody.should.have.keys('item'); |
There was a problem hiding this comment.
这个接口不应该返回列表么？我测试时返回的是单个对象
There was a problem hiding this comment.
数据问题，暂时不关注，可以看看examples/rs_listv2.js的注释
| @@ -134,3 +135,32 @@ exports.isQiniuCallback = function (mac, requestURI, reqBody, callbackAuth) { | |||
| var auth = exports.generateAccessToken(mac, requestURI, reqBody); | |||
| return auth === callbackAuth; | |||
| }; | |||
|
|
|||
| exports.prepareZone = function (ctx, accessKey, bucket, callback) { | |||
|
Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Math.ceilnycuseCacherefactor