queue: able to set max disk used bytes for diskQueue #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderflow
reviewed
Aug 14, 2018
queue/disk.go
Outdated
| opts.MemoryQueueSize = 100 | ||
| } | ||
|
|
||
| if opts.EnableDiskUsedLimit && opts.MaxDiskUsedBytes <= 0 { |
|
lgtm |
wonderflow
reviewed
Aug 14, 2018
| maxMemoryLength = 0 | ||
| } else if enableMemory && maxMemoryLength <= 0 { | ||
| maxMemoryLength = 100 | ||
| func NewDiskQueue(opts NewDiskQueueOptions) BackendQueue { |
There was a problem hiding this comment.
这样改这个包就不兼容了，到时候smartelf和logkit-pro升级要注意下
There was a problem hiding this comment.
本来就要多个参数编译就过不了的，一次性改成这种形式的以后更加方便添加更多选项
wonderflow
reviewed
Aug 14, 2018
queue/disk.go
Outdated
| d.writeOne(msg) | ||
| err := d.writeOne(msg) | ||
| if err != nil { | ||
| log.Errorf("DISKQUEUE(%s): drop one msg from memory chan - %v", d.name, err) |
There was a problem hiding this comment.
There was a problem hiding this comment.
如果 writeOne 一直失败就会无限循环退出不来
There was a problem hiding this comment.
如果 writeOne 一直失败就会无限循环退不出来
There was a problem hiding this comment.
不过之前就一直在丢数据... 这要怎么操作
Lines 793 to 800 in d044334
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.qiniu.io/browse/PDR-7002