Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reader/script: improve status check and implement DaemonReader and StatsReader #656

Merged
merged 1 commit into from
Jul 30, 2018
Merged

reader/script: improve status check and implement DaemonReader and StatsReader #656

merged 1 commit into from
Jul 30, 2018

Conversation

unknwon
Copy link
Contributor

@unknwon unknwon commented Jul 26, 2018

  1. 实现了 DaemonReader 和 StatsReader 接口
  2. 优化运行状态检查与关闭退出操作

@unknwon
Copy link
Contributor Author

unknwon commented Jul 30, 2018

已实测

image

@wonderflow
Copy link
Contributor

LGTM

wonderflow
wonderflow reviewed Jul 30, 2018
View reviewed changes
reader/script/script.go Outdated
time.Sleep(3 * time.Second)
}
log.Warnf("Runner[%v] %q task execution failed and gave up after 10 tries", r.meta.RunnerName, r.Name())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR级别

@wonderflow wonderflow merged commit 203b777 into qiniu:master Jul 30, 2018
@unknwon unknwon deleted the daemon-reader-start-script branch July 30, 2018 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonderflow wonderflow wonderflow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unknwon @wonderflow