fix: Compat for ts type error #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
=======================================
Coverage 40.00% 40.00%
=======================================
Files 7 7
Lines 455 455
Branches 98 99 +1
=======================================
Hits 182 182
Misses 271 271
Partials 2 2
Continue to review full report at Codecov.
|
yinxulai
reviewed
Feb 24, 2021
src/pool.ts
Outdated
| @@ -2,7 +2,7 @@ export type RunTask<T> = (...args: T[]) => Promise<void> | |||
|
|
|||
| export interface QueueContent<T> { | |||
| task: T | |||
| resolve: () => void | |||
| resolve: (value?: unknown) => void | |||
There was a problem hiding this comment.
实际上，这个问题导致的原因是 Pool 的 enqueue 方法在向 queue 添加任务时，创建 QueueContent 传递了类型不正确的 resolve导致的，而非 QueueContent 本身的类型问题，所以更好的办法应该是修复 enqueue 的内部实现
There was a problem hiding this comment.
推荐在 new Promise 时指定范型来使的 resolve 的类型推导正确
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #484