Bugfix/resumbleupload #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ((i + 1) * BLOCKSIZE > fsize) | ||
| readLen = (int)(fsize - i * BLOCKSIZE); | ||
| if ((long)(i + 1) * BLOCKSIZE > fsize) | ||
| readLen = (int)(fsize - (long)i * BLOCKSIZE); | ||
| byte[] byteBuf = new byte[readLen]; |
There was a problem hiding this comment.
这个 byteBuf 不用每次都 new 出来，应该提到 for 循环以外
| @@ -96,27 +98,15 @@ public CallRet PutFile(string upToken, string localFile, string key) | |||
| fsize = fs.Length; | |||
| chunks = fsize / extra.chunkSize + 1; | |||
There was a problem hiding this comment.
直接取消 chunk 概念，用 block_cnt 吧。
| @@ -21,14 +22,6 @@ public class ResumablePut | |||
| private const int blockMashk = (1 << blockBits) - 1; | |||
There was a problem hiding this comment.
这个为何不用blockMashk = BLOCKSIZE-1 清晰明了
|
LGTM, blockMashk = BLOCKSIZE-1 in next pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://pm.qbox.me/redmine/issues/7116
简化断点续上传，删除bput逻辑
修复bug：>2.5GB文件上传失败