fix(cron): use job.id instead of job.name for API calls#58
Merged
1186258278 merged 1 commit intoqingchencloud:mainfrom Mar 13, 2026
Merged
fix(cron): use job.id instead of job.name for API calls#581186258278 merged 1 commit intoqingchencloud:mainfrom
1186258278 merged 1 commit intoqingchencloud:mainfrom
Conversation
The cron job trigger button was passing job name instead of job id to the cron.run API, causing 'unknown cron job id' errors when jobs have custom names. Fixes: qingchencloud#1
Contributor
|
感谢 @axdlee 的贡献!🎉 这个修复很精准 — j.name || j.id 在有自定义名称时确实会导致 cron.run 传错参数。已 squash 合并到 main。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
The cron job trigger button was passing job name instead of job id to the cron.run API, causing 'unknown cron job id' errors when jobs have custom names.
Root Cause
In fetchJobs(), the job object was constructed with:
This caused the trigger button to pass name (e.g., "工作日订餐提醒") instead of id to cron.run.
Fix
Changes