Skip to content

fix bugs in handling argv/env with bytes#1380

Closed
noobone123 wants to merge 1 commit intoqilingframework:masterfrom
noobone123:master
Closed

fix bugs in handling argv/env with bytes#1380
noobone123 wants to merge 1 commit intoqilingframework:masterfrom
noobone123:master

Conversation

@noobone123
Copy link

@noobone123 noobone123 commented Sep 5, 2023

Checklist

fix #1379

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing


@elicn
Copy link
Member

elicn commented Sep 5, 2023

Thanks for the contribution, however this is quite non-elegant and should be implemented with more core-reuse.

@elicn
Copy link
Member

elicn commented Sep 21, 2023

Implemented as part of #1376

@elicn elicn closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

qiling framework has a potential issue when handling env parameters of type bytes.

2 participants