feat(os): add posix message queue syscalls#1363
Merged
xwings merged 4 commits intoqilingframework:devfrom Jul 4, 2023
Merged
Conversation
posix: add QlMsq to QlOsPosix syscalls: implement msgget, msgsnd, msgrcv
Mostly styling fixes. Fix handling of a few corner cases.
Styling fixes.
Overlooked indent error
Contributor
Author
|
Thanks for reviewing and refining the code. LGTM! |
xwings
approved these changes
Jul 4, 2023
Member
|
Hey, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To solve #1346, I implement
msgget,msgsnd,msgrcvsyscalls to fulfill the IPC syscall. To support message queue forQlOsPosix, I addQlMsq, a component similar to existingQlShm.If we want to support semaphore in the future, the code can be refactored to share code for different IPC objects, just as https://elixir.bootlin.com/linux/v5.19.17/source/ipc/util.c did.
Re-implementing syscalls is error-prone, and it is impossible to be exactly same as the original implementation. Simple examples or unit tests can be added to ensure the basic functionality.
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing