Skip to content

Improved handling of export table for invalid export address and removed GandCrab workaround in GetProcAddress #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kabeor merged 2 commits into from
Jul 4, 2023
Merged

Improved handling of export table for invalid export address and removed GandCrab workaround in GetProcAddress #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a64573
fixed bugs in export table and GetProcAddress
clairelevin Jun 1, 2023
41b3b83
added comment for export table fix
clairelevin Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions qiling/loader/pe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,10 @@ def init_exports(self, pe: pefile.PE):

# Do a full load if IMAGE_DIRECTORY_ENTRY_EXPORT is present so we can load the exports
pe.full_load()

# address corner case for malformed export tables where IMAGE_DIRECTORY_ENTRY_EXPORT exists, but DIRECTORY_ENTRY_EXPORT does not
if not hasattr(pe, 'DIRECTORY_ENTRY_EXPORT'):
return

iat = {}

Expand Down
4 changes: 0 additions & 4 deletions qiling/os/windows/dlls/kernel32/libloaderapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,6 @@ def hook_GetProcAddress(ql: Qiling, address: int, params):
# let log output reflect a human-readable procname
params["lpProcName"] = procname

# WORKAROUND for gandcrab
if procname == "RtlComputeCrc32":
return 0

procname = procname.encode('latin1')

else:
Expand Down