Fix regression caused by missing exception handling when opening socket#1124
Merged
kabeor merged 1 commit intoqilingframework:devfrom Apr 7, 2022
Merged
Fix regression caused by missing exception handling when opening socket#1124kabeor merged 1 commit intoqilingframework:devfrom
kabeor merged 1 commit intoqilingframework:devfrom
Conversation
chinggg
changed the title
elicn
requested changes
Apr 5, 2022
chinggg
force-pushed
the
fix-socket-except
branch
from
c63c261 to
dcf507d
Compare
elicn
approved these changes
Apr 5, 2022
kabeor
approved these changes
Apr 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing
closes #1122, which is a regression caused by removed exception block in 6989e5a