Add EVM ABI helpers, fix EVM DBG stack view#1123
Merged
kabeor merged 3 commits intoqilingframework:devfrom Apr 7, 2022
Merged
Conversation
kabeor
approved these changes
Apr 4, 2022
cla7aye15I4nd
approved these changes
Apr 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing
This PR adds some helper methods to deal with ABI encoding/decoding.
In particular I've renamed
converttoencode_paramswhile keeping backward compatibility, and I've addeddecode_params,encode_function_callandencode_function_call_abifunctions.This functions can be used to encode a contract function call and its parameter when the function prototype is known or when the ABI is available.
I've also added a new test for this functionality in the
tests/test_evm.py. The relevant lines from 126 to 137 highlight the new feature.Moreover I've fixed the display of the Stack in the EVM debugger.
When the stack was greater than 8, only the first 8 rows were displayed. Moreover the stack was growing top to bottom.
Now the stack displays the last 8 rows (the most recent and relevant ones) and grows bottom to top.
This can be tested with the following snippet as shown in the screenshot below: