New mem align and align_up methods#1051
Merged
kabeor merged 6 commits intoqilingframework:devfrom Dec 29, 2021
Merged
Conversation
xwings
approved these changes
Dec 29, 2021
kabeor
approved these changes
Dec 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally an alignment method would round values down to the alignment boundary. The current
mem.alignfunctionality, however, rounds values up - which is a bit unexpected. This PR changesmem.alignto round values down as one would expect, and adds a new methodmem.round_upto retain the old functionality in a more intuitive way.Changes:
mem.aligntomem.align_upmem.alignmethodmem.alignandmem.align_upwhere appropriate (code de-duplication)