[QHC-649] Move initialization of _qm into initial_setup
#763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillermoAbadLopez
requested review from
fedonman and
jordivallsq
and removed request for
fedonman and
jordivallsq
Base automatically changed from
bug-set_parameter-without-connection
to
qhc-588-bug-get_parameter-does-not-work-with-qm-platform
July 29, 2024 14:32
Base automatically changed from
qhc-588-bug-get_parameter-does-not-work-with-qm-platform
to
main
July 30, 2024 10:25
GuillermoAbadLopez
changed the title
_qm into initial_setup_qm into initial_setup
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #763 +/- ##
==========================================
- Coverage 94.97% 94.97% -0.01%
==========================================
Files 263 263
Lines 8640 8637 -3
==========================================
- Hits 8206 8203 -3
Misses 434 434
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes:
_qmand_qmmwas kind of mixed... (setup needed before turn_on..), now everything ininitial_setup()!Maybe it should also do:
post_init, so you can execute things without aninitial_setupas the documentation now states.. (This is not important since we are thinking about making it automatic/mandatory)