-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drivers/move_params_and_alias_to_abc #698
Open
GuillermoAbadLopez
wants to merge
11
commits into
main
Choose a base branch
from
drivers/move_params_and_alias_to_abc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillermoAbadLopez
force-pushed
the
drivers/move_params_and_alias_to_abc
branch
from
March 6, 2024 15:59
6c2c308
to
5c5b8fa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
==========================================
- Coverage 96.16% 96.11% -0.05%
==========================================
Files 273 273
Lines 9043 8941 -102
==========================================
- Hits 8696 8594 -102
Misses 347 347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the repeated
alias
andparams
properties from each driver, to use the qcodes basename
andparameters
My only question is if the word
alias
andparams
are needed:name
give incompatibilities with another name attribute or something somewhere (I don't think so).In such a case we then simple would need to keep this mapping:
But just once in a base class please, instead than repeating it for each individual driver (and if there is a weird case, then it can be overwritten there, but so far, all drivers have had the same repeated...)