Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drivers/move_params_and_alias_to_abc #698

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

GuillermoAbadLopez
Copy link
Contributor

@GuillermoAbadLopez GuillermoAbadLopez commented Mar 6, 2024

Removing the repeated alias and params properties from each driver, to use the qcodes base name and parameters

My only question is if the word alias and params are needed:

  • for some higher level functionality in qililab, and we cannot remove them completely,
  • or if name give incompatibilities with another name attribute or something somewhere (I don't think so).

In such a case we then simple would need to keep this mapping:

    @property
    def params(self):
        """return the parameters of the instrument"""
        return self.parameters

    @property
    def alias(self):
        """return the alias of the instrument, which corresponds to the QCodes name attribute"""
        return self.name

But just once in a base class please, instead than repeating it for each individual driver (and if there is a weird case, then it can be overwritten there, but so far, all drivers have had the same repeated...)

@GuillermoAbadLopez GuillermoAbadLopez force-pushed the drivers/move_params_and_alias_to_abc branch from 6c2c308 to 5c5b8fa Compare March 6, 2024 15:59
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (f4c356d) to head (fff3814).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
- Coverage   96.16%   96.11%   -0.05%     
==========================================
  Files         273      273              
  Lines        9043     8941     -102     
==========================================
- Hits         8696     8594     -102     
  Misses        347      347              
Flag Coverage Δ
unittests 96.11% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant