Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QHC-21] Make QProgram serializable #659

Merged
merged 19 commits into from
Jan 11, 2024

Conversation

fedonman
Copy link
Collaborator

@fedonman fedonman commented Jan 8, 2024

Added DictSerializable protocol and from_dict utility function to enable (de)serialization (from)to dictionary for any class.

Copy link

linear bot commented Jan 8, 2024

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba74196) 95.77% compared to head (a9c9d35) 95.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
+ Coverage   95.77%   95.82%   +0.05%     
==========================================
  Files         269      270       +1     
  Lines        8709     8815     +106     
==========================================
+ Hits         8341     8447     +106     
  Misses        368      368              
Flag Coverage Δ
unittests 95.82% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjmartinezQT jjmartinezQT self-requested a review January 9, 2024 13:42
Copy link
Collaborator

@jjmartinezQT jjmartinezQT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, very neat.

@jjmartinezQT jjmartinezQT merged commit 097bee6 into main Jan 11, 2024
6 checks passed
@jjmartinezQT jjmartinezQT deleted the qhc-21-qprogram-is-json-serialisable branch January 11, 2024 11:17
Copy link
Collaborator

@jjmartinezQT jjmartinezQT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants