-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QHC-64]Compilation at platform level #651
Conversation
…qilimanjaro-tech/qililab into compilation-at-platform/TAS-502
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 95.82% 95.98% +0.16%
==========================================
Files 270 271 +1
Lines 8815 8797 -18
==========================================
- Hits 8447 8444 -3
+ Misses 368 353 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very big PR changing core functionalities of qililab
. I think we should make 2 people review and approve the PR before merging it.
Yes, 100% agree with that. I also think testing it for some time on hardware before merging would be a good idea |
Co-authored-by: Albert Mitjans <a.mitjanscoma@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job to a quite difficult refactor!! 💯 💯
I have some ideas/questions to discuss with you as next steps, like if we could de-couple the compiler from the platform (don't pass the platform as a constructor parameter), but they are outside the scope of the PR.
Left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 💯
Summary
qblox_module
,qblox_qrm
,qblox_qcm
topulses.qblox_compiler