Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QHC-64]Compilation at platform level #651

Merged
merged 46 commits into from
Jan 15, 2024
Merged

Conversation

visagim
Copy link
Contributor

@visagim visagim commented Dec 22, 2023

  • Fix coverage
  • Changelog

Summary

  • Compilation tasks moved from qblox_module, qblox_qrm, qblox_qcm to pulses.qblox_compiler
  • Unified and removed some non-acquisition related settings from qrm / qcm under qblox_module
  • Improved / added some of the qblox modules tests which were missing
  • Removed bus related compiler methods

Copy link

linear bot commented Dec 22, 2023

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (097bee6) 95.82% compared to head (382d1f0) 95.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
+ Coverage   95.82%   95.98%   +0.16%     
==========================================
  Files         270      271       +1     
  Lines        8815     8797      -18     
==========================================
- Hits         8447     8444       -3     
+ Misses        368      353      -15     
Flag Coverage Δ
unittests 95.98% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@visagim visagim self-assigned this Jan 4, 2024
Copy link
Contributor

@AlbertMitjans AlbertMitjans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very big PR changing core functionalities of qililab. I think we should make 2 people review and approve the PR before merging it.

docs/releases/changelog-dev.md Outdated Show resolved Hide resolved
src/qililab/instruments/qblox/qblox_module.py Outdated Show resolved Hide resolved
src/qililab/instruments/qblox/qblox_module.py Outdated Show resolved Hide resolved
src/qililab/instruments/qblox/qblox_module.py Outdated Show resolved Hide resolved
src/qililab/platform/platform.py Outdated Show resolved Hide resolved
src/qililab/platform/platform.py Show resolved Hide resolved
@visagim
Copy link
Contributor Author

visagim commented Jan 8, 2024

This is a very big PR changing core functionalities of qililab. I think we should make 2 people review and approve the PR before merging it.

Yes, 100% agree with that. I also think testing it for some time on hardware before merging would be a good idea

@jjmartinezQT jjmartinezQT requested review from GuillermoAbadLopez and removed request for fedonman January 11, 2024 12:21
@visagim visagim requested a review from fedonman January 11, 2024 18:32
Copy link
Collaborator

@fedonman fedonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job to a quite difficult refactor!! 💯 💯

I have some ideas/questions to discuss with you as next steps, like if we could de-couple the compiler from the platform (don't pass the platform as a constructor parameter), but they are outside the scope of the PR.

Left some comments.

src/qililab/instruments/qblox/qblox_module.py Outdated Show resolved Hide resolved
src/qililab/instruments/qblox/qblox_module.py Outdated Show resolved Hide resolved
src/qililab/pulse/qblox_compiler.py Outdated Show resolved Hide resolved
src/qililab/pulse/qblox_compiler.py Show resolved Hide resolved
Copy link
Collaborator

@fedonman fedonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯

@visagim visagim merged commit c20b9fe into main Jan 15, 2024
6 checks passed
@visagim visagim deleted the compilation-at-platform/TAS-502 branch January 15, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants