Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QHC-57] Implement platform.execute_qprogram() for quantum machines #648

Merged
merged 70 commits into from
Jan 24, 2024
Merged

[QHC-57] Implement platform.execute_qprogram() for quantum machines #648

merged 70 commits into from
Jan 24, 2024

Conversation

fedonman
Copy link
Collaborator

@fedonman fedonman commented Dec 20, 2023 •
edited
Loading

Closes QHC-57, QHC-109, QHC-110, QHC-157, QHC-178, QHC-177, QHC-189

jjmartinezQT and others added 30 commits November 13, 2023 12:00
@jjmartinezQT
changes in buses
08e7fa9
@jjmartinezQT
Merge branch 'main' into feature/QM_config_translation
d097f89
@jjmartinezQT
removing extra settings on buses
7bc7e5d
@jjmartinezQT
changes in runcard and driver for QM manager
4c4d34f
@jjmartinezQT
progress in runcard translation
b3a0071
@jjmartinezQT
runcard example
d3f2ebe
@jjmartinezQT
changes in qmm
2645a78
@jjmartinezQT
changes in driver and runcard
2efa79b
@jjmartinezQT
temporary changes and files
0aeb266
@jjmartinezQT
removing import
94057e2
@jjmartinezQT
Merge branch 'main' into feature/QM_config_translation
92c37d6
@jjmartinezQT
using dictionary comprehension
651ec7a
@jjmartinezQT
code formatting
a91c27e
@jjmartinezQT
adding octaves back
8b427dd
@jjmartinezQT
test runcard
c9ebdba
@jjmartinezQT
test notebook
1de56a6
@fedonman
Merge branch 'main' into feature/QM_config_translation
06451b9
@fedonman
Edit runcard to qua config transpilation
b38b7b6
@fedonman
Edit runcard to qua config transpilation
30b0eea
@fedonman
updates in runcard
36de577
@fedonman
update QMM and move function to merge dictionaries to utils
a97bc90
@fedonman
update tests
cb0432f
@fedonman
remove runcards
0749368
@fedonman
update tests
ededed5
@fedonman
fix pylint
f04489d
@fedonman
update tests
0e321c3
@fedonman
Update QM after integration testing
234cebe
@fedonman
rename instrument and controller
b0f035f
@fedonman
merge from main
2ab68c2
@fedonman
update tests
527f494
@fedonman fedonman requested a review from visagim January 23, 2024 11:51
@linear Linear
Copy link

linear bot commented Jan 23, 2024

QHC-189 [BUG] Play instruction's wait via QProgram has the same duration as the waveform

visagim
visagim requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@visagim visagim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Just some minor questions. Once you confirm that this has been tested on hardware we can merge.

visagim
visagim approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@visagim visagim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead (after fixing the test that is failing)

@fedonman fedonman merged commit a67b887 into main Jan 24, 2024
6 checks passed
@fedonman fedonman deleted the qhc-57-implement-platformexecute_qprogram-for-quantum-machines branch January 24, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordivallsq jordivallsq jordivallsq left review comments

@visagim visagim visagim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fedonman @visagim @jordivallsq @jjmartinezQT