-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metapool + wallclock time updates #70
metapool + wallclock time updates #70
Conversation
@antgonza We will need these changes to qp-klp in addition to what was changed in mg-scripts. |
I'll review this after #69 is merged. |
@charles-cowart, conflicts after merging #69 |
@antgonza ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this full file changed, is that correct? or another way to ask this, what changed in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll confirm, one moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only meaningful change is the addition of the syndna_pool_number column in the [Data] section. However, since we've added a new column in the [Data] section, we had to add an additional ',' character to the end of each line in the other sections to preserve the sample-sheet specification. This will make every line appear as changed in any visual diff between the old and new.
Specifically, sample-sheets are in a tabular format with a uniform number of columns for each row, even though they can also be read like an INI file. The [Data] section usually determines the number of columns in a sample-sheet, since it has the largest number of required columns. This impacts the other sections by affecting the number of empty column values in their rows, captured by ',,...,'.
Since we added a column to the data section we had to add that column everywhere or else when the file is read into KLSampleSheet() and written back out, the output files won't be identical.
No description provided.