Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metapool + wallclock time updates #70

Merged
merged 11 commits into from
Sep 5, 2023

Conversation

charles-cowart
Copy link
Contributor

No description provided.

@charles-cowart
Copy link
Contributor Author

@antgonza We will need these changes to qp-klp in addition to what was changed in mg-scripts.

@antgonza
Copy link
Member

antgonza commented Aug 9, 2023

I'll review this after #69 is merged.

@charles-cowart
Copy link
Contributor Author

@antgonza This should still be reviewed after #69 is merged.

@antgonza
Copy link
Member

@charles-cowart, conflicts after merging #69

@charles-cowart charles-cowart changed the title Wallclock time update metapool + wallclock time updates Sep 1, 2023
@charles-cowart
Copy link
Contributor Author

@antgonza ready for review!

Copy link
Member

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions.

qp_klp/tests/data/good-sample-sheet.csv Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this full file changed, is that correct? or another way to ask this, what changed in this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll confirm, one moment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only meaningful change is the addition of the syndna_pool_number column in the [Data] section. However, since we've added a new column in the [Data] section, we had to add an additional ',' character to the end of each line in the other sections to preserve the sample-sheet specification. This will make every line appear as changed in any visual diff between the old and new.

Specifically, sample-sheets are in a tabular format with a uniform number of columns for each row, even though they can also be read like an INI file. The [Data] section usually determines the number of columns in a sample-sheet, since it has the largest number of required columns. This impacts the other sections by affecting the number of empty column values in their rows, captured by ',,...,'.

Since we added a column to the data section we had to add that column everywhere or else when the file is read into KLSampleSheet() and written back out, the output files won't be identical.

@antgonza antgonza merged commit 58c509d into qiita-spots:main Sep 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants