Potentially resolves the performance issues #961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 894dd7c on wasade:issue_887 into * on biocore:master*. |
|
Note, this performance issue was due to a local build issue on @antgonza's system. This has been resolved. However, this PR is still relevant as these properties and methods do not need to care about order (and they should not anyway as the order in the current structures in master is not assured) |
|
👍 |
|
👍 if testing is done |
|
👍 |
|
@wasade can this be merged now? Just asking because the initial comment still says "DO NOT MERGE" |
|
It has now been crossed out :) |
|
@adamrp @squirrelo You've been reviewing this PR, can you merge if it looks ok to you? |
antgonza
added a commit
that referenced
this pull request
Mar 18, 2015
Potentially resolves the performance issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #887
DO NOT MERGE, we are testing on a larger set of studies and analyses.