Skip to content

Conversation

@josenavas
Copy link
Contributor

Unifies all the 3 current repositories in a single repo.

QiiTa-ware was empty - I used it to create the single repo structure before porting it.
QiiTa-pet: the only important thing that it had was the HMP2 demo, which has been ported under the prototypes folder - all the extra code that @squirrelo and I developed has to be refactored so no need to port here.
QiiTa: it had the mongodb prototype, which is still located under the prototypes folder

The QiiTa-db API should be complete while the QiiTa-ware API is still not finished, but I think it is useful to merge and we can all start working on different parts of the code, as well as start adding issues for the needed functionality and/or any additions/modifications to the APIs.

@antgonza
Copy link
Member

We did a pretty extensive code review during yesterday's meeting,
should we merge as is or does anybody want to do an actual review
(~1000 files)? My vote is merge.

@squirrelo
Copy link
Contributor

I say merge as-is, but I may be a bit biased.

@josenavas
Copy link
Contributor Author

I did the few changes that we discussed yesterday, if somebody wants to review is ok, but my vote goes to merge and anything found create an issue. It will allow to continue with the development of the entire project.

@ElDeveloper
Copy link
Contributor

I can take a quick pass.

On Jan 29, 2014, at 2:39 PM, josenavas notifications@github.com wrote:

I did the few changes that we discussed yesterday, if somebody wants to review is ok, but my vote goes to merge and anything found create an issue. It will allow to continue with the development of the entire project.


Reply to this email directly or view it on GitHub.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but: Qiita -> QiiTa?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo is now Qiita and not QiiTa, remember?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that, ok.

On Jan 29, 2014, at 2:41 PM, Antonio Gonzalez notifications@github.com wrote:

In prototypes/HMP2/README.md:

@@ -0,0 +1,40 @@
+QiiTa-pet
+=================
+
+Qiita web frontend based on a tornado-redis-celery setup with a login system, push notifications on celery jobs, and file uploads.
The logo is now Qiita and not QiiTa, remember?

Reply to this email directly or view it on GitHub.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mean to beat a dead horse, but is there a reason the T is capitalized in our official spelling? I have heard some opinions from around the lab (and I kind of agree) that it looks pretty good lower-cased.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the logo is lower-case, I think it makes sense to have it lower-cased everywhere. There is a lot of references through the code, so I'll try to change all of them.

However, I'm not going to change anything from the HMP2 demo folder, since we want to have it as it was on the demo, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@ElDeveloper
Copy link
Contributor

👍

@ElDeveloper
Copy link
Contributor

I didn't get a chance to talk with @josenavas, but after this should I delete QiiTa-ware and QiiTa-pet?

@antgonza
Copy link
Member

Yes

@josenavas
Copy link
Contributor Author

I've changed all references from QiiTa to Qiita

@josenavas
Copy link
Contributor Author


@antgonza
Copy link
Member

We are waiting on Yoshiki to finish his comments.

@ElDeveloper
Copy link
Contributor

Minor details:

  • In qiita/qiita_core/exceptions.py change IncompetentQiitaDeveloper -> IncompetentQiitaDeveloperError to follow along with all the other exception names.
  • qiita/qiita_pet/__init__.py the credits are missing.
  • qiita/qiita_ware/api/__init__.py the credits are missing.
  • qiita/qiita_ware/core/__init__.py the credits are missing.
  • qiita/qiita_ware/core/exceptions.py some of these exceptions are oddly named, I would change AnalysisNotExistsError to AnalysisDoesNotExistsError or AnalysisNotFoundError. Same thing for other exceptions here.

Sorry I couldn't make the comments inline but GitHubs interface fails with large PRs.

@josenavas
Copy link
Contributor Author

I fixed your comments. Thanks!

And yes, the GitHub interface with large PRs does not work correctly, I noticed that...

@ElDeveloper
Copy link
Contributor

👍 thanks!

ElDeveloper added a commit that referenced this pull request Jan 31, 2014
Unify all the repositories
@ElDeveloper ElDeveloper merged commit efffafc into qiita-spots:master Jan 31, 2014
@josenavas josenavas deleted the unify branch January 31, 2014 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants