-
Couldn't load subscription status.
- Fork 79
Unify all the repositories #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We did a pretty extensive code review during yesterday's meeting, |
|
I say merge as-is, but I may be a bit biased. |
|
I did the few changes that we discussed yesterday, if somebody wants to review is ok, but my vote goes to merge and anything found create an issue. It will allow to continue with the development of the entire project. |
|
I can take a quick pass. On Jan 29, 2014, at 2:39 PM, josenavas notifications@github.com wrote:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor but: Qiita -> QiiTa?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logo is now Qiita and not QiiTa, remember?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that, ok.
On Jan 29, 2014, at 2:41 PM, Antonio Gonzalez notifications@github.com wrote:
In prototypes/HMP2/README.md:
@@ -0,0 +1,40 @@
+QiiTa-pet
+=================
+
+Qiita web frontend based on a tornado-redis-celery setup with a login system, push notifications on celery jobs, and file uploads.
The logo is now Qiita and not QiiTa, remember?
—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't mean to beat a dead horse, but is there a reason the T is capitalized in our official spelling? I have heard some opinions from around the lab (and I kind of agree) that it looks pretty good lower-cased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the logo is lower-case, I think it makes sense to have it lower-cased everywhere. There is a lot of references through the code, so I'll try to change all of them.
However, I'm not going to change anything from the HMP2 demo folder, since we want to have it as it was on the demo, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
|
👍 |
|
I didn't get a chance to talk with @josenavas, but after this should I delete QiiTa-ware and QiiTa-pet? |
|
Yes |
|
I've changed all references from QiiTa to Qiita |
|
We are waiting on Yoshiki to finish his comments. |
|
Minor details:
Sorry I couldn't make the comments inline but GitHubs interface fails with large PRs. |
|
I fixed your comments. Thanks! And yes, the GitHub interface with large PRs does not work correctly, I noticed that... |
|
👍 thanks! |
Unify all the repositories


Unifies all the 3 current repositories in a single repo.
QiiTa-ware was empty - I used it to create the single repo structure before porting it.
QiiTa-pet: the only important thing that it had was the HMP2 demo, which has been ported under the prototypes folder - all the extra code that @squirrelo and I developed has to be refactored so no need to port here.
QiiTa: it had the mongodb prototype, which is still located under the prototypes folder
The QiiTa-db API should be complete while the QiiTa-ware API is still not finished, but I think it is useful to merge and we can all start working on different parts of the code, as well as start adding issues for the needed functionality and/or any additions/modifications to the APIs.