Skip to content

REL: Pre-Alpha release 0.0.1 #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 25, 2014
Merged

REL: Pre-Alpha release 0.0.1 #689

merged 10 commits into from
Nov 25, 2014

Conversation

ElDeveloper
Copy link
Contributor

This pull request includes updates that were necessary to make qiita usable
when installed via pip, this is a summary of the changes:

  • Classifiers and documentation strings in setup.py have been updated.
  • setup.py now imports and installs the resources that are needed for the website to work properly (templates, static resources, etc).
  • The webserver is no longer started by running the nefarious python qiita_pet/webserver.py; to start the webserver simply do: qiita webserver start.
  • The inclusion of the webserver subcommand into the qiita needed the import of the application to be done as part of the subcommand itself, therefore you will see that from qiita_pet.webserver import Application is not at the top of the file.
  • qiita webserver start includes an argument to specify the port --port.
  • The installation documentation has been updated to reflect the current status of the project.

To properly test this PR, create a new virtual environment, follow the instructions in INSTALL.md.

To emulate pip install qiita try:

pip install https://github.com/ElDeveloper/qiita/archive/release-0.0.1.zip

⚠️ Note ⚠️ that I won't upload to pypi until:

1.- this PR is merged.

2.- We can get rid of this package https://pypi.python.org/pypi/qiita/0.1.1 @wasade, I think you created that, can you remove it? If that wasn't you @wasade, does anyone know about who created that?

@wasade
Copy link
Contributor

wasade commented Nov 25, 2014

Someone named heavenshell created it
On Nov 24, 2014 5:35 PM, "Yoshiki Vázquez Baeza" notifications@github.com
wrote:

This pull request includes updates that were necessary to make qiita usable
when installed via pip, this is a summary of the changes:

  • Classifiers and documentation strings in setup.py have been updated.
  • setup.py now imports and installs the resources that are needed for
    the website to work properly (templates, static resources, etc).
  • The webserver is no longer started by running the nefarious python
    qiita_pet/webserver.py; to start the webserver simply do: qiita
    webserver start.
  • The inclusion of the webserver subcommand into the qiita needed the
    import of the application to be done as part of the subcommand itself,
    therefore you will see that from qiita_pet.webserver import Application
    is not at the top of the file.
  • qiita webserver start includes an argument to specify the port --port
    .
  • The installation documentation has been updated to reflect the
    current status of the project.

To properly test this PR, create a new virtual environment, follow the
instructions in INSTALL.md.

To emulate pip install qiita try:

pip install https://github.com/ElDeveloper/qiita/archive/release-0.0.1.zip

[image: ⚠️] Note [image: ⚠️] that I won't upload to pypi
until:

1.- this PR is merged.

2.- We can get rid of this package
https://pypi.python.org/pypi/qiita/0.1.1 @wasade
https://github.com/wasade, I think you created that, can you remove it?
If that wasn't you @wasade https://github.com/wasade, does anyone know

about who created that?

You can merge this Pull Request by running

git pull https://github.com/ElDeveloper/qiita release-0.0.1

Or view, comment on, or merge it at:

#689
Commit Summary

  • REL: Minor cleanup for qiita
  • BLD: Add missing files to setup.py
  • MAINT: Move application startup to qiita
  • BLD: Add more missing paths
  • MAINT: Move import inside a sub-command
  • DOC: Update installation documentation

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#689.

@josenavas
Copy link
Contributor

It doesn't look like it is our software....

2014-11-24 18:40 GMT-07:00 Daniel McDonald notifications@github.com:

Someone named heavenshell created it
On Nov 24, 2014 5:35 PM, "Yoshiki Vázquez Baeza" notifications@github.com

wrote:

This pull request includes updates that were necessary to make qiita
usable
when installed via pip, this is a summary of the changes:

  • Classifiers and documentation strings in setup.py have been updated.
  • setup.py now imports and installs the resources that are needed for
    the website to work properly (templates, static resources, etc).
  • The webserver is no longer started by running the nefarious python
    qiita_pet/webserver.py; to start the webserver simply do: qiita
    webserver start.
  • The inclusion of the webserver subcommand into the qiita needed the
    import of the application to be done as part of the subcommand itself,
    therefore you will see that from qiita_pet.webserver import Application
    is not at the top of the file.
  • qiita webserver start includes an argument to specify the port --port
    .
  • The installation documentation has been updated to reflect the
    current status of the project.

To properly test this PR, create a new virtual environment, follow the
instructions in INSTALL.md.

To emulate pip install qiita try:

pip install
https://github.com/ElDeveloper/qiita/archive/release-0.0.1.zip

[image: ⚠️] Note [image: ⚠️] that I won't upload to pypi
until:

1.- this PR is merged.

2.- We can get rid of this package
https://pypi.python.org/pypi/qiita/0.1.1 @wasade
https://github.com/wasade, I think you created that, can you remove
it?
If that wasn't you @wasade https://github.com/wasade, does anyone
know

about who created that?

You can merge this Pull Request by running

git pull https://github.com/ElDeveloper/qiita release-0.0.1

Or view, comment on, or merge it at:

#689
Commit Summary

  • REL: Minor cleanup for qiita
  • BLD: Add missing files to setup.py
  • MAINT: Move application startup to qiita
  • BLD: Add more missing paths
  • MAINT: Move import inside a sub-command
  • DOC: Update installation documentation

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#689.

—
Reply to this email directly or view it on GitHub
#689 (comment).

Jose Navas

@ElDeveloper
Copy link
Contributor Author

Thanks for catching that! That means that we nee to change the name of our package, maybe python-qiita or qiita-web?

Yoshiki Vázquez-Baeza

On Nov 24, 2014, at 6:40 PM, Daniel McDonald notifications@github.com wrote:

Someone named heavenshell created it
On Nov 24, 2014 5:35 PM, "Yoshiki Vázquez Baeza" notifications@github.com
wrote:

This pull request includes updates that were necessary to make qiita usable
when installed via pip, this is a summary of the changes:

  • Classifiers and documentation strings in setup.py have been updated.
  • setup.py now imports and installs the resources that are needed for
    the website to work properly (templates, static resources, etc).
  • The webserver is no longer started by running the nefarious python
    qiita_pet/webserver.py; to start the webserver simply do: qiita
    webserver start.
  • The inclusion of the webserver subcommand into the qiita needed the
    import of the application to be done as part of the subcommand itself,
    therefore you will see that from qiita_pet.webserver import Application
    is not at the top of the file.
  • qiita webserver start includes an argument to specify the port --port
    .
  • The installation documentation has been updated to reflect the
    current status of the project.

To properly test this PR, create a new virtual environment, follow the
instructions in INSTALL.md.

To emulate pip install qiita try:

pip install https://github.com/ElDeveloper/qiita/archive/release-0.0.1.zip

[image: ⚠️] Note [image: ⚠️] that I won't upload to pypi
until:

1.- this PR is merged.

2.- We can get rid of this package
https://pypi.python.org/pypi/qiita/0.1.1 @wasade
https://github.com/wasade, I think you created that, can you remove it?
If that wasn't you @wasade https://github.com/wasade, does anyone know

about who created that?

You can merge this Pull Request by running

git pull https://github.com/ElDeveloper/qiita release-0.0.1

Or view, comment on, or merge it at:

#689
Commit Summary

  • REL: Minor cleanup for qiita
  • BLD: Add missing files to setup.py
  • MAINT: Move application startup to qiita
  • BLD: Add more missing paths
  • MAINT: Move import inside a sub-command
  • DOC: Update installation documentation

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#689.

—
Reply to this email directly or view it on GitHub.

@wasade
Copy link
Contributor

wasade commented Nov 25, 2014

Maybe we reach out to the author?
On Nov 24, 2014 5:43 PM, "Yoshiki Vázquez Baeza" notifications@github.com
wrote:

Thanks for catching that! That means that we nee to change the name of our
package, maybe python-qiita or qiita-web?

Yoshiki Vázquez-Baeza

On Nov 24, 2014, at 6:40 PM, Daniel McDonald notifications@github.com
wrote:

Someone named heavenshell created it
On Nov 24, 2014 5:35 PM, "Yoshiki Vázquez Baeza" <
notifications@github.com>
wrote:

This pull request includes updates that were necessary to make qiita
usable
when installed via pip, this is a summary of the changes:

  • Classifiers and documentation strings in setup.py have been updated.
  • setup.py now imports and installs the resources that are needed for
    the website to work properly (templates, static resources, etc).
  • The webserver is no longer started by running the nefarious python
    qiita_pet/webserver.py; to start the webserver simply do: qiita
    webserver start.
  • The inclusion of the webserver subcommand into the qiita needed the
    import of the application to be done as part of the subcommand itself,
    therefore you will see that from qiita_pet.webserver import
    Application
    is not at the top of the file.
  • qiita webserver start includes an argument to specify the port
    --port
    .
  • The installation documentation has been updated to reflect the
    current status of the project.

To properly test this PR, create a new virtual environment, follow the
instructions in INSTALL.md.

To emulate pip install qiita try:

pip install
https://github.com/ElDeveloper/qiita/archive/release-0.0.1.zip

[image: ⚠️] Note [image: ⚠️] that I won't upload to pypi
until:

1.- this PR is merged.

2.- We can get rid of this package
https://pypi.python.org/pypi/qiita/0.1.1 @wasade
https://github.com/wasade, I think you created that, can you remove
it?
If that wasn't you @wasade https://github.com/wasade, does anyone
know

about who created that?

You can merge this Pull Request by running

git pull https://github.com/ElDeveloper/qiita release-0.0.1

Or view, comment on, or merge it at:

#689
Commit Summary

  • REL: Minor cleanup for qiita
  • BLD: Add missing files to setup.py
  • MAINT: Move application startup to qiita
  • BLD: Add more missing paths
  • MAINT: Move import inside a sub-command
  • DOC: Update installation documentation

File Changes

(25)

Patch Links:

—
Reply to this email directly or view it on GitHub
#689.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#689 (comment).

@adamrp
Copy link
Contributor

adamrp commented Nov 25, 2014

Considering qiita_db + qiita_ware is going to be QIIME 2, I think it's okay
to call this PyQiitaor something like that. Later, when QIIME 2 is
released, we can rebrand this package as qiita-pet or qiita-ui or something
like that.

On Mon, Nov 24, 2014 at 6:48 PM, Daniel McDonald notifications@github.com
wrote:

Maybe we reach out to the author?
On Nov 24, 2014 5:43 PM, "Yoshiki Vázquez Baeza" notifications@github.com

wrote:

Thanks for catching that! That means that we nee to change the name of
our
package, maybe python-qiita or qiita-web?

Yoshiki Vázquez-Baeza

On Nov 24, 2014, at 6:40 PM, Daniel McDonald notifications@github.com

wrote:

Someone named heavenshell created it
On Nov 24, 2014 5:35 PM, "Yoshiki Vázquez Baeza" <
notifications@github.com>
wrote:

This pull request includes updates that were necessary to make qiita
usable
when installed via pip, this is a summary of the changes:

  • Classifiers and documentation strings in setup.py have been
    updated.
  • setup.py now imports and installs the resources that are needed
    for
    the website to work properly (templates, static resources, etc).
  • The webserver is no longer started by running the nefarious python
    qiita_pet/webserver.py; to start the webserver simply do: qiita
    webserver start.
  • The inclusion of the webserver subcommand into the qiita needed
    the
    import of the application to be done as part of the subcommand
    itself,
    therefore you will see that from qiita_pet.webserver import
    Application
    is not at the top of the file.
  • qiita webserver start includes an argument to specify the port
    --port
    .
  • The installation documentation has been updated to reflect the
    current status of the project.

To properly test this PR, create a new virtual environment, follow
the
instructions in INSTALL.md.

To emulate pip install qiita try:

pip install
https://github.com/ElDeveloper/qiita/archive/release-0.0.1.zip

[image: ⚠️] Note [image: ⚠️] that I won't upload to
pypi
until:

1.- this PR is merged.

2.- We can get rid of this package
https://pypi.python.org/pypi/qiita/0.1.1 @wasade
https://github.com/wasade, I think you created that, can you
remove
it?
If that wasn't you @wasade https://github.com/wasade, does anyone
know

about who created that?

You can merge this Pull Request by running

git pull https://github.com/ElDeveloper/qiita release-0.0.1

Or view, comment on, or merge it at:

#689
Commit Summary

  • REL: Minor cleanup for qiita
  • BLD: Add missing files to setup.py
  • MAINT: Move application startup to qiita
  • BLD: Add more missing paths
  • MAINT: Move import inside a sub-command
  • DOC: Update installation documentation

File Changes

(25)

Patch Links:

—
Reply to this email directly or view it on GitHub
#689.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#689 (comment).

—
Reply to this email directly or view it on GitHub
#689 (comment).

adamrp
adamrp reviewed Nov 25, 2014
View reviewed changes
INSTALL.md
@@ -22,28 +22,50 @@ Qiita is a python package, with support for python 2.7 and 3.2, that depends on
* [networkx](http://networkx.lanl.gov/index.html)
* [WTForms 2.0.1](https://wtforms.readthedocs.org/en/latest/)
* [Mock](http://www.voidspace.org.uk/python/mock/) For running test code only
* [redis 2.8.0](https://pypi.python.org/pypi/redis/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redis is listed twice in this list. This one (redis 2.8.0) is more descriptive, so can you delete the other one?

@adamrp
Copy link
Contributor

adamrp commented Nov 25, 2014

Thanks @ElDeveloper (and @antgonza?) for putting this together -- really exciting to see this nearing a real release 😃

@ElDeveloper
Copy link
Contributor Author

I will need to know what we want to call the package before this is merged, current options:

  • py-qiita
  • python-qiita
  • qiita-web-app
  • PyQiitaor -> pyqiitaor
  • qiita-sp (spot patterns)

Note that this is the name that our package will have in pypi.

@josenavas
Copy link
Contributor

I like qiita-sp

@antgonza
Copy link
Member

What about qiita-spot(s)?

@ElDeveloper
Copy link
Contributor Author

@antgonza suggested qiitas.

On (Nov-24-14|20:05), josenavas wrote:

I like qiita-sp

Reply to this email directly or view it on GitHub:
#689 (comment)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) when pulling e9fa574 on ElDeveloper:release-0.0.1 into a0628e5 on biocore:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) when pulling e9fa574 on ElDeveloper:release-0.0.1 into a0628e5 on biocore:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) when pulling 13d2db9 on ElDeveloper:release-0.0.1 into a0628e5 on biocore:master.

@ElDeveloper
Copy link
Contributor Author

☝️

sloučit
fusionere
συγχώνευση
merge
спојити

antgonza added a commit that referenced this pull request Nov 25, 2014
@antgonza
Merge pull request #689 from ElDeveloper/release-0.0.1
b0f91f9 
REL: Pre-Alpha release 0.0.1
@antgonza antgonza merged commit b0f91f9 into qiita-spots:master Nov 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ElDeveloper @wasade @josenavas @adamrp @antgonza @coveralls