actual fix #688
Merged
actual fix #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,5 +42,29 @@ def test_get_accessible_filepath_ids(self): | |||
| obs = get_accessible_filepath_ids('shared@foo.bar') | |||
| self.assertEqual(obs, set()) | |||
|
|
|||
| # Test that it doesn't brake if the SampleTemplate hasn't been added | |||
| exp = set([1, 2, 3, 4, 5, 6, 7, 11L, 14, 15, 16]) | |||
There was a problem hiding this comment.
does the 11 have to be 11L for some reason? just curious
|
👍 thanks for catching this, @antgonza, and thanks for adding the test! |
|
👍 |
|
Thanks, let's wait for the tests to pass and this should be ready for merge. |
ElDeveloper
added a commit
that referenced
this pull request
Nov 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.