Skip to content

Adding qiime map file #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 24, 2014
Merged

Conversation

antgonza
Copy link
Member

This adds the creation of the qiime mapping file (combination of prep/sample template) at the when the prep template is added. Note that the code is ready for review, it tests pass, but we should merge #677 first.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.14%) when pulling c07967b on antgonza:adding-qiime-map-file into d29f2fe on biocore:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.14%) when pulling 4dae65c on antgonza:adding-qiime-map-file into d29f2fe on biocore:master.

@antgonza
Copy link
Member Author

This is ready for review.

Parameters
----------
prep_template_fp : str
The filepath of the prep template we want to generate the qiime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revise this sentence?

@ElDeveloper
Copy link
Contributor

This PR reminded me that we have not created that micro-package to deal with QIIME mapping files. Once we have that, we should replace as needed. Not sure if it would be worth creating an issue about that or not.

This works great, I applied the patch, accessed a study got a QIIME mapping file and then was able to open it (with vim) and started playing around with it! I was even able to get validate_mapping_file.py to go through an example and the only oddity it found were "extraneous" characters i. e. (, but that is not really a problem.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) when pulling 010332b on antgonza:adding-qiime-map-file into b5d257d on biocore:master.

----------
prep_template_fp : str
The prep template filepath that should be concatenated to the
study template go used to generate a new QIIME mapping file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

study -> sample

@josenavas
Copy link
Contributor

Few comments @antgonza
It is a bit weird that we are relying on the filepaths to create the qiime mapping file (so we can parse them into pandas). I remember correctly, there is a function that @ElDeveloper wrote to transform a MetadataTemplate into a pandas DataFrame. I think the way to go is to make a function on the MetadataTemplate object called to_dataframe that returns a DataFrame with the template information.

@antgonza
Copy link
Member Author

The new commit should address @josenavas comments, note that I have created #680 so we can discuss the refactoring of create_qiime_mapping_file.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) when pulling e2e0a05 on antgonza:adding-qiime-map-file into b5d257d on biocore:master.

@ElDeveloper
Copy link
Contributor

👍

ElDeveloper added a commit that referenced this pull request Nov 24, 2014
@ElDeveloper ElDeveloper merged commit e1f1ace into qiita-spots:master Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants