-
Notifications
You must be signed in to change notification settings - Fork 80
Adding qiime map file #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding qiime map file #678
Conversation
…-qiime-map-file
…-qiime-map-file
…dding-qiime-map-file
This is ready for review. |
Parameters | ||
---------- | ||
prep_template_fp : str | ||
The filepath of the prep template we want to generate the qiime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revise this sentence?
This PR reminded me that we have not created that micro-package to deal with QIIME mapping files. Once we have that, we should replace as needed. Not sure if it would be worth creating an issue about that or not. This works great, I applied the patch, accessed a study got a QIIME mapping file and then was able to open it (with vim) and started playing around with it! I was even able to get |
…-qiime-map-file
---------- | ||
prep_template_fp : str | ||
The prep template filepath that should be concatenated to the | ||
study template go used to generate a new QIIME mapping file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
study
-> sample
Few comments @antgonza |
The new commit should address @josenavas comments, note that I have created #680 so we can discuss the refactoring of create_qiime_mapping_file. |
👍 |
This adds the creation of the qiime mapping file (combination of prep/sample template) at the when the prep template is added. Note that the code is ready for review, it tests pass, but we should merge #677 first.