Skip to content

updating JS libraries 2022.02 #3177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

antgonza
Copy link
Member

Here I'm updating all possible JS libraries to their latests:

  • jquery: 2.1.0 -> 3.6.0
  • jquery-ui: 1.11.1 -> 1.13.1
  • jquery chosen: 1.1.0 -> 1.8.7
  • jquery dataTables: 1.10.13 -> 1.11.4
  • jQuery Validation: v1.12.0 -> 1.19.3
  • vue: 2.1.6 -> 2.6.14
  • Select2: 4.0.2 -> 4.0.13
  • SlickGrid: 2.2 -> 2.4.44
  • jquery.event.drag: 2.2 -> 2.3.0
  • Cytoscape.js: 3.18.2 -> 3.20.0
  • cytoscape-dagre.js 2.3.2 -> 2.4.0
  • Note that Bootstrap was kept at 3.3.7 even as there is a much newer version (5.1.3); the reason behind that is because a change like that will mean rewriting all boostrap calls, see: https://stackoverflow.com/q/68004792

Replaced:

  • tag-it -> tagify 4.9.6

Removing (as they are no longer used):

  • underscore.min.js
  • string.min.js

@coveralls
Copy link

coveralls commented Feb 15, 2022

Coverage Status

coverage: 92.9% (+0.008%) from 92.892%
when pulling d18ac46 on antgonza:update-JS-libraries-01.2022
into cd1dbeb on qiita-spots:dev.

Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I largely passed over the updated files in the vendor directory; I'll assume they were vetted by the vendor. Just a few questions to confirm and I can approve and merge.

Copy link
Member Author

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. 'Hello' string will be described in a separate issue.

@charles-cowart charles-cowart merged commit 3bdfb81 into qiita-spots:dev Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants