New network #3096
Merged
New network #3096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasade
requested changes
Apr 28, 2021
qiita_pet/static/js/networkVue.js
Outdated
| vm.network.on("stabilized", function (params) { | ||
| // Note: we only need to sort the edges to keep the same structure of the | ||
| // graph; in other words, nodes order is not important | ||
| vm.edges = vm.edges.sort((a, b) => (a.data.source > b.data.source) ? 1 : (a.data.source === b.data.source) ? ((a.data.target > b.data.target) ? 1 : -1) : -1 ); |
There was a problem hiding this comment.
Triple nested ternary is a bit hard... any chance this could be refactored? I think it would be:
Suggested change
| vm.edges = vm.edges.sort((a, b) => (a.data.source > b.data.source) ? 1 : (a.data.source === b.data.source) ? ((a.data.target > b.data.target) ? 1 : -1) : -1 ); | |
| var sort_order = -1; | |
| if ((a.data.source > b.data.source) || ((a.data.source === b.data.source) && (a.data.target > b.data.target)) { | |
| sort_order = 1; | |
| } | |
| vm.edges = vm.edges.sort(sort_order); |
There was a problem hiding this comment.
Sounds good, just note that this is a function like in python list.sort(key=sorting_function).
There was a problem hiding this comment.
oh right, so pack into a function... but main item was, if okay, to expand the nested ternaries :)
qiita_pet/static/js/networkVue.js
Outdated
| var data = evt.target.data(); | ||
| var element_id = data.id; | ||
|
|
||
| if (data.group == 'artifact') { |
There was a problem hiding this comment.
minor i think here, but possible to use === to be consistent with the other equalities?
qiita_pet/static/js/networkVue.js
Outdated
| if (data.group == 'artifact') { | ||
| vm.populateContentArtifact(element_id); | ||
| } else if (clickedNode.group == 'deleting') { | ||
| } else if (data.group == 'deleting') { |
antgonza
commented
Apr 28, 2021
qiita_pet/static/js/networkVue.js
Outdated
| vm.network.on("stabilized", function (params) { | ||
| // Note: we only need to sort the edges to keep the same structure of the | ||
| // graph; in other words, nodes order is not important | ||
| vm.edges = vm.edges.sort((a, b) => (a.data.source > b.data.source) ? 1 : (a.data.source === b.data.source) ? ((a.data.target > b.data.target) ? 1 : -1) : -1 ); |
There was a problem hiding this comment.
Sounds good, just note that this is a function like in python list.sort(key=sorting_function).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of libraries/files being updated and moved that do not need review; reviewers should focus on: