fix #2839 #3029
fix #2839 #3029
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #3029 +/- ##
=======================================
Coverage 94.94% 94.95%
=======================================
Files 74 74
Lines 14275 14291 +16
=======================================
+ Hits 13554 13570 +16
Misses 721 721
Continue to review full report at Codecov.
|
| add_ebi_accessions : bool, optional | ||
| If this should add the ebi accessions | ||
| """ | ||
| df = self._common_to_dataframe_steps() |
There was a problem hiding this comment.
what about:
accessions = None
if add_ebi_accessions:
accessions = self.ebi_sample_accessions
return self._common_to_dataframe_steps(accessions, 'ebi_sample_accessions')...similar for the prep template to_dataframe, and then add into the common function:
if accessions is not None:
df[f'qiita_{accession_type}'] = df.index.map(lambda sid: accessions[sid])
Would reduce a little of code duplication
There was a problem hiding this comment.
not strong feeling about leaving as is or changing ...
i think :)| df = self._common_to_dataframe_steps() | ||
|
|
||
| if add_ebi_accessions: | ||
| accessions = self.ebi_sample_accessions |
There was a problem hiding this comment.
Are all samples assured to be represented in this object? If not, would it be safer to have the lambda issue a accessions.get?
There was a problem hiding this comment.
yes, AFAIK all samples in the prep/sample are represented.
| df = self._common_to_dataframe_steps() | ||
|
|
||
| if add_ebi_accessions: | ||
| accessions = self.ebi_sample_accessions |
There was a problem hiding this comment.
yes, AFAIK all samples in the prep/sample are represented.
| add_ebi_accessions : bool, optional | ||
| If this should add the ebi accessions | ||
| """ | ||
| df = self._common_to_dataframe_steps() |
There was a problem hiding this comment.
not strong feeling about leaving as is or changing ...
3 participants
No description provided.