Skip to content

Conversation

@antgonza
Copy link
Member

@antgonza antgonza commented Apr 28, 2020

Depends on (please review/merge those one first):

@antgonza antgonza requested a review from ElDeveloper April 28, 2020 20:55
@antgonza antgonza changed the title 052020 [WIP] 052020 May 5, 2020
@antgonza antgonza changed the title [WIP] 052020 052020 May 5, 2020
@antgonza
Copy link
Member Author

antgonza commented May 5, 2020

@ElDeveloper, this is ready for review. BTW It's also deployed in qiita-rc.

Copy link
Contributor

@ElDeveloper ElDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @antgonza, just a few notes on the ChangeLog.

CHANGELOG.md Outdated

* Added Metatrascriptomicas as a data type, added a Ribosomal read filtering step and documentation on how to use it in the processing recommendations
* Fixed issue that prevented creating new artifacts when it was the children of a public parent
* Qiita now keeps track of the delete artifact jobs which avoids creating duplicated delete jobs and the user gets this feedback in the GUI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Qiita now keeps track of the delete artifact jobs which avoids creating duplicated delete jobs and the user gets this feedback in the GUI
* Qiita now keeps track of artifact deletion jobs, prevents submitting duplicated deletions, and the GUI is updated when an artifact is being deleted

CHANGELOG.md Outdated
* Qiita now keeps track of the delete artifact jobs which avoids creating duplicated delete jobs and the user gets this feedback in the GUI
* We now display the `redbiom` DB release date in the redbiom Qiita page
* Fixed EBA-ENA duplicated sample submission in multiple preparations - this could happen when a sample existed in more than one preparation
* Now is possible to deprecate a full preparation; this is useful when there is an unsuccessful run/preparation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Now is possible to deprecate a full preparation; this is useful when there is an unsuccessful run/preparation
* Add the ability to deprecate a preparation; this is useful when there is an unsuccessful run or preparation

CHANGELOG.md Outdated
* Now is possible to deprecate a full preparation; this is useful when there is an unsuccessful run/preparation
* The study page now has a markdown `Notes` section so users add problematic samples, explaining certain metadata columns, etc
* Added user documentation to better explain how to split your samples in preparations
* Removed unused-legacy code to deal with duplicated sample names while building analyses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Removed unused-legacy code to deal with duplicated sample names while building analyses
* Fix a bug where repeated sample names were incorrectly handled during meta-analysis (#2978). Removed unused-legacy code to deal with duplicated sample names while building analyses.

CHANGELOG.md Outdated
* Added user documentation to better explain how to split your samples in preparations
* Removed unused-legacy code to deal with duplicated sample names while building analyses
* Improved headings in the stats page to avoid confusions
* Fixed annoying issue that only deleted selected samples within the page viewing frame
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fixed annoying issue that only deleted selected samples within the page viewing frame
* Fixed issue that only deleted selected samples within the page's viewing frame

CHANGELOG.md Outdated
* Improved headings in the stats page to avoid confusions
* Fixed annoying issue that only deleted selected samples within the page viewing frame
* Qiita now uses `gnu=True` in the `humanize.naturalsize` so the size display matches what a user sees when they `ls` the file
* Updated code so it works with the latest version of `pandas`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind listing the exact version?

@ElDeveloper ElDeveloper merged commit 530bc06 into qiita-spots:dev May 5, 2020
@ElDeveloper
Copy link
Contributor

Thanks @antgonza !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants