Skip to content

Conversation

@antgonza
Copy link
Member

In this PR:

  • re-add line so matplotlib works fine
  • self.assertItemsEqual -> self.assertCountEqual
  • fix all qiita_core
  • fix all processing_job

Note that the biggest differences in networkx versions are:

  • before when calling edges/nodes/etc it used to return a dict and now returns a tuple
  • all the lists are of the type vs. just a list, for example: nodes, returns NodeView(()) vs []

@charles-cowart
Copy link
Contributor

52 files is a lot, but most of the changes are straightforward enough (method name change, slight parameter syntax change, etc.). There is one line where I'd like your comment, just to know what it's doing, and to confirm that it should still be there.

@antgonza
Copy link
Member Author

Thanks for review, I have addressed your comments ...

@charles-cowart charles-cowart merged commit f0c0483 into qiita-spots:python3.6 Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants