Skip to content

Conversation

@antgonza
Copy link
Member

@antgonza antgonza commented Oct 6, 2018

This is intentionally going to master because we want to have an updated version of the README and cause the changes in qiita-recover-jobs made possible the deblur reprocessing and job recovery after power outage.

README.rst Outdated
* Full study management: Create, delete, update samples in the sample and
multiple preparation information files.
* Upload files via direct drag & drop from the web interface or via scp
from any server that allows this connections.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this -> these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

README.rst Outdated
* Upload files via direct drag & drop from the web interface or via scp
from any server that allows this connections.
* Study privacy management: Sandboxed -> Private -> Public.
* Easy long term sequence data deposition to the European Nucleotide Archive (ENA),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

long term -> long-term

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

def _flush_queues(recover_type):
# README: in theory we should be able to submit all recover_type jobs
# one after the other but in reality that's not possible. The issue
# is that a job is going to stay as running/waiting until is completed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completed. Thus

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - a few minor requests.

Copy link
Member Author

@antgonza antgonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes made, thanks for review.

README.rst Outdated
* Full study management: Create, delete, update samples in the sample and
multiple preparation information files.
* Upload files via direct drag & drop from the web interface or via scp
from any server that allows this connections.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

README.rst Outdated
* Upload files via direct drag & drop from the web interface or via scp
from any server that allows this connections.
* Study privacy management: Sandboxed -> Private -> Public.
* Easy long term sequence data deposition to the European Nucleotide Archive (ENA),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

def _flush_queues(recover_type):
# README: in theory we should be able to submit all recover_type jobs
# one after the other but in reality that's not possible. The issue
# is that a job is going to stay as running/waiting until is completed
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

@codecov-io
Copy link

Codecov Report

Merging #2695 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2695   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files         166      166           
  Lines       19747    19747           
=======================================
  Hits        18626    18626           
  Misses       1121     1121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd47ca8...a36b4f4. Read the comment docs.

@charles-cowart charles-cowart merged commit 214cfdd into qiita-spots:master Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants