-
Couldn't load subscription status.
- Fork 79
Update current features #2695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update current features #2695
Conversation
README.rst
Outdated
| * Full study management: Create, delete, update samples in the sample and | ||
| multiple preparation information files. | ||
| * Upload files via direct drag & drop from the web interface or via scp | ||
| from any server that allows this connections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this -> these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
README.rst
Outdated
| * Upload files via direct drag & drop from the web interface or via scp | ||
| from any server that allows this connections. | ||
| * Study privacy management: Sandboxed -> Private -> Public. | ||
| * Easy long term sequence data deposition to the European Nucleotide Archive (ENA), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
long term -> long-term
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k
scripts/qiita-recover-jobs
Outdated
| def _flush_queues(recover_type): | ||
| # README: in theory we should be able to submit all recover_type jobs | ||
| # one after the other but in reality that's not possible. The issue | ||
| # is that a job is going to stay as running/waiting until is completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
completed. Thus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - a few minor requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes made, thanks for review.
README.rst
Outdated
| * Full study management: Create, delete, update samples in the sample and | ||
| multiple preparation information files. | ||
| * Upload files via direct drag & drop from the web interface or via scp | ||
| from any server that allows this connections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
README.rst
Outdated
| * Upload files via direct drag & drop from the web interface or via scp | ||
| from any server that allows this connections. | ||
| * Study privacy management: Sandboxed -> Private -> Public. | ||
| * Easy long term sequence data deposition to the European Nucleotide Archive (ENA), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k
scripts/qiita-recover-jobs
Outdated
| def _flush_queues(recover_type): | ||
| # README: in theory we should be able to submit all recover_type jobs | ||
| # one after the other but in reality that's not possible. The issue | ||
| # is that a job is going to stay as running/waiting until is completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k
Codecov Report
@@ Coverage Diff @@
## master #2695 +/- ##
=======================================
Coverage 94.32% 94.32%
=======================================
Files 166 166
Lines 19747 19747
=======================================
Hits 18626 18626
Misses 1121 1121Continue to review full report at Codecov.
|
This is intentionally going to master because we want to have an updated version of the README and cause the changes in
qiita-recover-jobsmade possible the deblur reprocessing and job recovery after power outage.