Adding SCP GUI #2662
Merged
Adding SCP GUI #2662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strips UTF-8 characters from study titles UTF-8 characters that are not also printable ASCII characters are stripped from new study titles, as well as existing studies flagged 'public'. This is because study titles are passed as metadata to new analyses, and some analysis packages may not work well with them.
Merging charles-cowart->66.py with another topic branch 66.py
Merged 66.py with that from qiita-spots#2660
This was referenced Sep 6, 2018
Merged
Codecov Report
@@ Coverage Diff @@
## dev #2662 +/- ##
==========================================
- Coverage 94.38% 94.31% -0.08%
==========================================
Files 166 166
Lines 19563 19653 +90
==========================================
+ Hits 18465 18536 +71
- Misses 1098 1117 +19
Continue to review full report at Codecov.
|
charles-cowart
approved these changes
Sep 11, 2018
|
Thanks for review @charles-cowart, what about merging and then I add that comment in the next pr as I need to fix conflicts on that one too ... |
|
Sure - you'd like me to do the merge then?
…On Tue, Sep 11, 2018 at 1:14 PM, Antonio Gonzalez ***@***.***> wrote:
Thanks for review @charles-cowart <https://github.com/charles-cowart>,
what about merging and then I add that comment in the next pr as I need to
fix conflicts on that one too ...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2662 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AotPk6g1ImSt5t-sNaE87N74_zNAOo_rks5uaBmigaJpZM4Wdju4>
.
|
|
👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First review/merge: #2658 because I already pulled those changes to avoid future SQL patch conflicts.
See functionality, just testing listing cause download works the same way but takes much longer cause it downloads the files:
Note that I had to add study_id to the list_remote_files method so we could store in redis the results.