Skip to content

Conversation

@antgonza
Copy link
Member

Found 3 things:

  • By mistake left a hardcoded value, replacing for a variable vm.studyId
  • The study list had an extra field:
    screen shot 2018-05-25 at 11 45 37 am
  • While testing the EBI submission caught that if we try modify an error will be raised.

@codecov-io
Copy link

Codecov Report

Merging #2596 into release-candidate will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-candidate    #2596   +/-   ##
==================================================
  Coverage              94.44%   94.44%           
==================================================
  Files                    160      160           
  Lines                  19523    19523           
==================================================
  Hits                   18439    18439           
  Misses                  1084     1084

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a88d9...6afb10a. Read the comment docs.

$('#user-studies-table').dataTable({
"lengthMenu": [[5, 10, 50, -1], [5, 10, 50, "All"]],
"deferRender": true,
"sDom": '<"top">rti<"bottom"p>',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this <"bottom"p> syntax. but if this is ok, then the rest looks fine

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax comes from: http://legacy.datatables.net/usage/options, but the screenshot shows the differences.

@tkosciolek tkosciolek merged commit 2ce85a8 into qiita-spots:release-candidate May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants