fix #1067 #2507
Merged
fix #1067 #2507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2507 +/- ##
==========================================
- Coverage 94.63% 94.55% -0.09%
==========================================
Files 160 160
Lines 19457 19474 +17
==========================================
- Hits 18414 18413 -1
- Misses 1043 1061 +18
Continue to review full report at Codecov.
|
ElDeveloper
suggested changes
Feb 21, 2018
qiita_db/environment_manager.py
Outdated
| admin_conn.execute('CREATE DATABASE %s' % qiita_config.database) | ||
| except ValueError as error: | ||
| # if database exists, ignore if sett | ||
| if 'database "qiita_test" already exists' in error.message: |
There was a problem hiding this comment.
This will only work if the database is named qiita_test ... perhaps it should look for:
if 'database "%s" already exists' % qiita_config.database in error.message:
...
ElDeveloper
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing 1067. Note that decided to make it easier by checking if the database exists and the installation is test to overwrite.