Skip to content

Conversation

@antgonza
Copy link
Member

Before:
before
After:
after

Note that this adds the functionality but we will need to update the qiita-spots:

  • qtp-biom,
  • qtp-visualization,
  • qtp-diversity,
  • qtp-target-gene &
  • qtp-template-cookiecutter

to actually use this new functionality.

@codecov-io
Copy link

codecov-io commented Jan 26, 2018

Codecov Report

Merging #2478 into dev will increase coverage by 0.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #2478      +/-   ##
=========================================
+ Coverage   94.17%   94.6%   +0.43%     
=========================================
  Files         166     160       -6     
  Lines       19563   19452     -111     
=========================================
- Hits        18423   18403      -20     
+ Misses       1140    1049      -91
Impacted Files Coverage Δ
...iita_pet/handlers/api_proxy/tests/test_artifact.py 98.22% <ø> (ø) ⬆️
qiita_db/test/test_artifact.py 99.85% <100%> (ø) ⬆️
qiita_pet/handlers/study_handlers/artifact.py 95.45% <100%> (ø) ⬆️
qiita_db/artifact.py 98.28% <100%> (ø) ⬆️
qiita_db/handlers/tests/test_artifact.py 97.36% <100%> (ø) ⬆️
qiita_db/handlers/artifact.py 97.46% <100%> (+0.03%) ⬆️
qiita_db/archive.py 90% <0%> (-6.67%) ⬇️
qiita_db/handlers/reference.py 91.66% <0%> (ø) ⬆️
qiita_db/user.py 94.83% <0%> (ø) ⬆️
qiita_pet/handlers/logger_handlers.py 69.56% <0%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94cae1...349064c. Read the comment docs.

Copy link
Contributor

@ElDeveloper ElDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, only minor suggestion would be to change "can_be_raw" for "is_user_uploadable". Or something that clearly says that a user can upload this artifact type.

Copy link
Contributor

@sjanssen2 sjanssen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only one minor comment and my endorsement for this feature

study_id = self.get_argument("study_id")
prep_id = self.get_argument("prep_template_id")
artifact_types = artifact_types_get_req()['types']
artifact_types = [(at, desc) for at, desc, _, _, raw in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is "raw" short for "is_user_uploadable", if so you might want to use it here explicitly to emphasize the filtering criterion

@sjanssen2 sjanssen2 merged commit 1adcc75 into qiita-spots:dev Feb 2, 2018
@antgonza antgonza deleted the fix-2280 branch February 17, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants