-
Notifications
You must be signed in to change notification settings - Fork 79
fix #2280 #2478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #2280 #2478
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2478 +/- ##
=========================================
+ Coverage 94.17% 94.6% +0.43%
=========================================
Files 166 160 -6
Lines 19563 19452 -111
=========================================
- Hits 18423 18403 -20
+ Misses 1140 1049 -91
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, only minor suggestion would be to change "can_be_raw" for "is_user_uploadable". Or something that clearly says that a user can upload this artifact type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, only one minor comment and my endorsement for this feature
| study_id = self.get_argument("study_id") | ||
| prep_id = self.get_argument("prep_template_id") | ||
| artifact_types = artifact_types_get_req()['types'] | ||
| artifact_types = [(at, desc) for at, desc, _, _, raw in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is "raw" short for "is_user_uploadable", if so you might want to use it here explicitly to emphasize the filtering criterion
Before:


After:
Note that this adds the functionality but we will need to update the qiita-spots:
to actually use this new functionality.