Addressing Tomasz's issues #2441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2441 +/- ##
=======================================
Coverage 94.14% 94.14%
=======================================
Files 164 164
Lines 19390 19390
=======================================
Hits 18254 18254
Misses 1136 1136Continue to review full report at Codecov.
|
antgonza
reviewed
Dec 17, 2017
qiita_pet/static/js/networkVue.js
Outdated
|
|
||
| /** | ||
| * | ||
| * Funtion to format the node labels so they don't overlap |
qiita_pet/static/js/networkVue.js
Outdated
| var limit = 35; | ||
| // Split the input string by the space characters | ||
| var labelArray = label.split(' '); | ||
| // For the new label |
There was a problem hiding this comment.
For the new label? Not sure what it means ...
qiita_pet/static/js/networkVue.js
Outdated
| var newLabel = labelArray[0]; | ||
| var aux; | ||
| var lastNewLineIdx = 0; | ||
| // Note that the foor loop starts with 1 because we have already used the |
| var labelArray = label.split(' '); | ||
| // For the new label | ||
| var newLabel = labelArray[0]; | ||
| var aux; |
There was a problem hiding this comment.
Do we really need this variable declared here or can we just declare it within the for loop (line 27)?
There was a problem hiding this comment.
I prefer to declare it here rather than being it declared in each iteration of the for loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the div under the network with the rest of the page.
Adds a function to make sure the a single line of a node label is no longer than 35 characters. If it is, it just changes the last space on that line by a new line.