Fixing adding command problem #2437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carolina and Stephanie found an issue in the qiita-rc system: if you tried to add a command to an artifact that has not been generated and the job generating it has been already submitted (i.e. no longer in construction), the system failed with a really weird error. Adding a command to those types of artifacts is not easy, there are a lot of assumptions perform through the code that rely on this behavior not happening, and removing all them is complex. For the time being, I've disabled the ability to add commands to those type of artifacts (you can still add commands if the workflow is in construction). Instead it shows a little information about that (there is not too much to show, but at least it doesn't fail and you see something on the screen). GIF with the resulting changes: