Skip to content

Conversation

@josenavas
Copy link
Contributor

Carolina and Stephanie found an issue in the qiita-rc system: if you tried to add a command to an artifact that has not been generated and the job generating it has been already submitted (i.e. no longer in construction), the system failed with a really weird error. Adding a command to those types of artifacts is not easy, there are a lot of assumptions perform through the code that rely on this behavior not happening, and removing all them is complex. For the time being, I've disabled the ability to add commands to those type of artifacts (you can still add commands if the workflow is in construction). Instead it shows a little information about that (there is not too much to show, but at least it doesn't fail and you see something on the screen). GIF with the resulting changes:

futureresult

@codecov-io
Copy link

Codecov Report

Merging #2437 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2437   +/-   ##
=======================================
  Coverage   94.06%   94.06%           
=======================================
  Files         163      163           
  Lines       19347    19347           
=======================================
  Hits        18199    18199           
  Misses       1148     1148

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9866ca...d19405f. Read the comment docs.

@josenavas
Copy link
Contributor Author

@antgonza @ElDeveloper available for a review?

@ElDeveloper ElDeveloper merged commit 782a7c2 into qiita-spots:dev Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants