Skip to content

Conversation

@josenavas
Copy link
Contributor

  • I found a bug in the qiita-rc (and live system) in which not all validators contain the parameter "analysis" and not all calls were passing this value. This generated several problem in different parts of the system. Not sure why the error didn't show up earlier. I've modified the current patch to make sure that all Validate commands have that command. All new commands have that parameter already added, so it is just for backwards compatibility.
  • The default active tab in the prep information is now the processing.
  • A border has been added to the inactive pills - so you can clearly see that are clickable:
    screen shot 2017-12-14 at 8 44 56 pm
  • The buttons for show/hide the graph and to run the workflow are now align:
    screen shot 2017-12-14 at 8 46 15 pm
  • Changed "Update information" to "Update prep information"
  • By luck I found the source of the issue for the navigation buttons, so fixes Add navigation controls to network views #2231. Note: since now this works as expected, you actually have to click on the graph to enable interaction, and click outside the graph to disable interaction. Thus, the button is no longer need (and I removed) and I have not found a way of changing this behavior.
    screen shot 2017-12-14 at 8 49 59 pm
  • Finally, I've improved the uploads page. When the file is in the system, a tick appears next to the file. If the file is being uploaded, a blinking upload icon is next to the file name.
    upload

@codecov-io
Copy link

Codecov Report

Merging #2436 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2436   +/-   ##
=======================================
  Coverage   94.06%   94.06%           
=======================================
  Files         163      163           
  Lines       19347    19347           
=======================================
  Hits        18199    18199           
  Misses       1148     1148
Impacted Files Coverage Δ
qiita_pet/handlers/api_proxy/artifact.py 99.19% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa48b37...85088e8. Read the comment docs.

@antgonza antgonza merged commit f9866ca into qiita-spots:dev Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants