-
Couldn't load subscription status.
- Fork 79
Make Sample Information Page reactive #2429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ving stuff from the API proxy
Codecov Report
@@ Coverage Diff @@
## dev #2429 +/- ##
==========================================
+ Coverage 93.87% 94.09% +0.22%
==========================================
Files 163 163
Lines 19236 19335 +99
==========================================
+ Hits 18057 18193 +136
+ Misses 1179 1142 -37
Continue to review full report at Codecov.
|
The PR ended up being smaller than I expected (although I know is still pretty big). In this PR I modified the Sample Information Page so now it is reactive and automatically reloads the different sections of the page as needed.
Here is a GIF showing the changes - I'm not cheating the page is reloading alone xD.

While making these changes I found 2 bugs that I also fixed here: (1) when changing the visibility of an artifact the code was calling a function that no longer exists and (2) it turns out that in master, if you are accessing a public study which you are NOT the owner you're still presented with the buttons to delete samples (o.O) - this was pretty bad and unsure how long has been in the system (my guess is since forever), but I fixed it here. Also a GIF showing these changes: