Skip to content

Conversation

@josenavas
Copy link
Contributor

The PR ended up being smaller than I expected (although I know is still pretty big). In this PR I modified the Sample Information Page so now it is reactive and automatically reloads the different sections of the page as needed.

Here is a GIF showing the changes - I'm not cheating the page is reloading alone xD.
stimprovements

While making these changes I found 2 bugs that I also fixed here: (1) when changing the visibility of an artifact the code was calling a function that no longer exists and (2) it turns out that in master, if you are accessing a public study which you are NOT the owner you're still presented with the buttons to delete samples (o.O) - this was pretty bad and unsure how long has been in the system (my guess is since forever), but I fixed it here. Also a GIF showing these changes:

otherbugfixesd

@josenavas
Copy link
Contributor Author

Forgot to mention that it fixes the sample information related items from this issue #2185

and also #2389

@codecov-io
Copy link

Codecov Report

Merging #2429 into dev will increase coverage by 0.22%.
The diff coverage is 99.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2429      +/-   ##
==========================================
+ Coverage   93.87%   94.09%   +0.22%     
==========================================
  Files         163      163              
  Lines       19236    19335      +99     
==========================================
+ Hits        18057    18193     +136     
+ Misses       1179     1142      -37
Impacted Files Coverage Δ
...t/handlers/study_handlers/tests/test_processing.py 97.29% <ø> (ø) ⬆️
...ta_pet/handlers/api_proxy/tests/test_processing.py 99.12% <ø> (ø) ⬆️
qiita_pet/webserver.py 100% <ø> (ø) ⬆️
...dlers/study_handlers/tests/test_sample_template.py 99.51% <100%> (+2.01%) ⬆️
qiita_db/test/test_software.py 99.8% <100%> (ø) ⬆️
qiita_pet/handlers/study_handlers/__init__.py 100% <100%> (ø) ⬆️
qiita_pet/handlers/api_proxy/sample_template.py 96.62% <100%> (+0.93%) ⬆️
qiita_pet/handlers/api_proxy/processing.py 87.75% <100%> (+0.25%) ⬆️
qiita_pet/handlers/api_proxy/__init__.py 100% <100%> (ø) ⬆️
...t/handlers/api_proxy/tests/test_sample_template.py 97.76% <100%> (-0.79%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4885e57...6578b54. Read the comment docs.

@antgonza antgonza merged commit 94e08b2 into qiita-spots:dev Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants