-
Notifications
You must be signed in to change notification settings - Fork 80
Update redbiom.html #2377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update redbiom.html #2377
Conversation
Codecov Report
@@ Coverage Diff @@
## release-candidate #2377 +/- ##
==================================================
Coverage 93.77% 93.77%
==================================================
Files 163 163
Lines 18668 18668
==================================================
Hits 17505 17505
Misses 1163 1163 Continue to review full report at Codecov.
|
@@ -208,18 +208,31 @@ | |||
<ul> | |||
<li> | |||
Find all samples in which the word infant exists, as well as antibiotics, | |||
where the infants are under a certain number of days old: | |||
"infant & antibiotics where age_days < 30" | |||
where the infants are under a year old: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember that this is HTML so it will not render as it's written. If you want a new line you will need to use <br/>
, if you want to create a list you could do:
<ul>
<li>element 1</li>
<li>element 2</li>
</ul>
and please use &
for all the &
ping @adswafford |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed html based on feedback from @antgonza
Left out where "ph< 7 & emp_release1 == True" because the search didn't produce any results; does the metadata need to be updated or is there a different metadata category used to denote the EMP first release?
"ph< 7 & emp_release1 == True" needs to be "where ph < 7 and emp_release1 == 'True'". If you're testing against redbiom-rc, then this should work. If you're not testing against redbiom-rc, then it won't work as the state of the database at the old load did not include "emp_release1" |
Still no luck at least on qiita-rc, but not sure if this is pointed at
redbiom-rc? Also, the message says the query is malformed?
[image: Inline image 1]
…On Mon, Oct 30, 2017 at 10:00 AM, Daniel McDonald ***@***.***> wrote:
"ph< 7 & emp_release1 == True" needs to be "where ph < 7 and emp_release1
== 'True'".
If you're testing against redbiom-rc, then this should work. If you're not
testing against redbiom-rc, then it won't work as the state of the database
at the old load did not include "emp_release1"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2377 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AZxBhgkyWPWhGGGjqGdhL59lAPty1IOGks5sxgCbgaJpZM4QIeUD>
.
|
Not sure, works for me against $ redbiom search metadata "where ph < 7 and emp_release1 == 'True'" | wc -l
1176 |
Gotcha. I just tried to go to qiita-rc again now to test and it looks like
the system is down/updating, but we should check that it's working through
the GUI before we put it in the list of examples.
…On Mon, Oct 30, 2017 at 11:21 AM, Daniel McDonald ***@***.***> wrote:
Not sure, works for me against redbiom-rc:
$ redbiom search metadata "where ph < 7 and emp_release1 == 'True'" | wc -l
1176
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2377 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AZxBhs0_c86V5mK8h7Exrp2P27GuDCoYks5sxhOxgaJpZM4QIeUD>
.
|
@adswafford we are currently updating the qiita-rc to do a dry upgrade, to ensure the success of tomorrow's main system update. |
Figured out the issue: in booleans 'True' != 'true', which shouldn't be an issue but fixing in redbiom will take longer than fixing in Qiita. The problem in Qiita is that we were lower everything which was solved and this is not a problem with other queries, for example:
Just tested in qiita-rc (deployed the fix) and now To fix this PR, I'm gonna close it and issue a new one. |
closing in favor of: #2382 |
No description provided.