fix #2333 #2356
fix #2333 #2356
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2356 +/- ##
==========================================
+ Coverage 93.77% 93.77% +<.01%
==========================================
Files 163 163
Lines 18593 18597 +4
==========================================
+ Hits 17436 17440 +4
Misses 1157 1157
Continue to review full report at Codecov.
|
| SELECT parameter_set_name, array_agg(parameter_set) AS param_set | ||
| FROM qiita.default_parameter_set | ||
| GROUP BY parameter_set_name""" | ||
| sql_params = """SELECT default_parameter_set_id, command_id, |
There was a problem hiding this comment.
I think in this query the param_set value will always have a single value. In the GROUP BY clause you've included the "default_parameter_set_id" which is the primary key of the table "default_parameter_set". Thus, it is impossible for two rows in the table to have the same default_parameter_set_id.
There was a problem hiding this comment.
right and in the code below we are only getting the first value [0], changing.
4 participants
This definitely wasn't an easy fix: @adswafford.
Displaying the parent's processing name beside the artifacts was already implemented. However, the implementation assumed that each default_parameter_set was unique, which is not true (lots of 'Defaults') and the code was "getting confused" between them. This is solved in these code changes. I also made the search/match of parameters per command so that steps happens faster.
Additionally, we realized that for some reason (still looking into this) there is a difference between the trimming version in Qiita. The difference is that the length is being stored as string/int - this is the only command in the full database that has this problem (checked several times, this morning again). Thus, we need to discuss this during tomorrow's meeting.