Skip to content

fix #2316 #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2017
Merged

fix #2316 #2351

merged 2 commits into from
Oct 19, 2017

Conversation

@antgonza
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 13, 2017 •
edited
Loading

Codecov Report

Merging #2351 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2351   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files         163      163           
  Lines       18589    18589           
=======================================
  Hits        17435    17435           
  Misses       1154     1154

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 097e1bc...65ee914. Read the comment docs.

wasade
wasade reviewed Oct 16, 2017
View reviewed changes
qiita_pet/templates/redbiom.html
var text = $(elements[idx]).text();
elements = text.split(" | ");
artifacts += parseInt(elements[0].split(": ")[1]);
samples += parseInt(elements[1].split(": ")[1]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's actually being summed here? the number of samples in a study or artifacts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent question. In the code below (lines 48-56) we count the number of artifacts and samples per study (row). Here we are building the footer to show the total so we could recount all studies/artifacts/samples or just loop over the totals (each row) and parse out the numbers to add. The format of each row is: 'Artifacts: ## | Samples: ##'.

@wasade wasade merged commit 2b000fc into qiita-spots:dev Oct 19, 2017
@antgonza antgonza mentioned this pull request Oct 19, 2017
Closed
@antgonza antgonza deleted the fix-2316 branch February 17, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wasade wasade wasade approved these changes

+1 more reviewer

@josenavas josenavas josenavas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antgonza @codecov-io @wasade @josenavas