Skip to content

Delete study with tags #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

antgonza
Copy link
Member

on top of #2306 (so merge that one first) to avoid more multiple commits issues.

@antgonza antgonza changed the base branch from master to release-candidate September 21, 2017 13:34
@codecov-io
Copy link

codecov-io commented Sep 21, 2017

Codecov Report

Merging #2309 into release-candidate will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release-candidate   #2309      +/-   ##
====================================================
+ Coverage               93.8%   93.8%   +<.01%     
====================================================
  Files                    163     163              
  Lines                  18579   18581       +2     
====================================================
+ Hits                   17428   17430       +2     
  Misses                  1151    1151
Impacted Files Coverage Δ
qiita_db/study.py 97.32% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a30c79...b9ce206. Read the comment docs.

Copy link
Contributor

@josenavas josenavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given tests pass

@josenavas josenavas merged commit 5b14656 into qiita-spots:release-candidate Sep 21, 2017
@antgonza antgonza deleted the delete-study-with-tags branch February 17, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants