Skip to content

Conversation

@antgonza
Copy link
Member

While working on this I realized that format_biom_rows was duplicated with similar functionality so decided to merge them. Also that qiita_pet/templates/artifact_ajax/artifact_summary.html should be an input and not a link so the js works as expected.

Copy link
Contributor

@josenavas josenavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but tests are failing.

@codecov-io
Copy link

codecov-io commented Sep 16, 2017

Codecov Report

Merging #2288 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2288      +/-   ##
==========================================
+ Coverage   93.84%   93.84%   +<.01%     
==========================================
  Files         163      163              
  Lines       18494    18498       +4     
==========================================
+ Hits        17356    17360       +4     
  Misses       1138     1138
Impacted Files Coverage Δ
qiita_pet/test/test_qiita_redbiom.py 98.43% <100%> (+0.02%) ⬆️
qiita_pet/handlers/qiita_redbiom.py 94.8% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9aa1c4...38e5cd7. Read the comment docs.

@josenavas josenavas merged commit ae3dc0c into qiita-spots:dev Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants