fix #2258 #2287
fix #2258 #2287
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2287 +/- ##
==========================================
+ Coverage 93.81% 93.84% +0.02%
==========================================
Files 163 163
Lines 18427 18494 +67
==========================================
+ Hits 17288 17356 +68
+ Misses 1139 1138 -1
Continue to review full report at Codecov.
|
|
by mistake I added the fixes for #2251 also here. I think this PR has an OK size so I'm gonna leave as this. BTW the study page looks like this: |
qiita_pet/handlers/download.py
Outdated
| self.set_header('Expires', '0') | ||
| self.set_header('Cache-Control', 'no-cache') | ||
| self.set_header('Content-Disposition', 'attachment; ' | ||
| 'filename=ebi_sample_accessions_study_%s.tsv' % sid) |
There was a problem hiding this comment.
Can you change the name of the file here so it's not the same as above? I would say something along the lines of ebi_experiment_accessions_study_%s_prep_%s.tsv
There was a problem hiding this comment.
good catch, I forgot to change that!
| @@ -222,3 +230,59 @@ def get(self, study_id): | |||
| self.set_header('Content-Disposition', | |||
| 'attachment; filename=%s' % zip_fn) | |||
| self.finish() | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
These two handlers are doing pretty much the same, can this be factored in to a base class or in a helper function?
No description provided.