Skip to content

Conversation

@antgonza
Copy link
Member

this one is built on top of #2261, so review/merge that one first.

@josenavas
Copy link
Contributor

@antgonza can you pull from upstream/remove-moi so those changes go away?

Thanks!

@codecov-io
Copy link

codecov-io commented Aug 31, 2017

Codecov Report

Merging #2262 into remove-moi will increase coverage by 0.76%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           remove-moi    #2262      +/-   ##
==============================================
+ Coverage       95.62%   96.38%   +0.76%     
==============================================
  Files              75       66       -9     
  Lines           13021    12469     -552     
==============================================
- Hits            12451    12018     -433     
+ Misses            570      451     -119
Impacted Files Coverage Δ
qiita_db/handlers/tests/oauthbase.py 100% <100%> (ø) ⬆️
qiita_db/handlers/tests/test_oauth2.py 99.34% <100%> (ø) ⬆️
qiita_db/meta_util.py 91.62% <100%> (-0.04%) ⬇️
qiita_db/test/test_meta_util.py 98.87% <100%> (-0.01%) ⬇️
qiita_db/handlers/oauth2.py 92.36% <100%> (ø) ⬆️
qiita_core/exceptions.py
qiita_core/environment_manager.py
qiita_core/tests/test_util.py
qiita_core/tests/test_configuration_manager.py
qiita_core/configuration_manager.py
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 120e9ac...58e2dab. Read the comment docs.

@josenavas josenavas merged commit 8b4ce80 into qiita-spots:remove-moi Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants