Fixes 1880

[josenavas]

Fixes #1880
Basically the problem was in this function:

https://github.com/biocore/qiita/blob/a369cad63827b92e89032c8e12d5865c61f73a5b/qiita_ware/dispatchable.py#L198-L204

The serial calls to extend and update was forcing a validation on the "extend" call first (which raised the warning message) and another on the update, which it corrected the values in the DB (but didn't remove the previous warning).

By creating a function that performs those 2 operations at the same time and issuing a single validation at the end of that function we only raise a warning at the end if there is a problem with the data in the DB at the end of the operation.

[codecov-io]

Codecov Report

Merging #2247 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #2247      +/-   ##
==========================================
+ Coverage   92.81%   92.82%   +0.01%     
==========================================
  Files         171      171              
  Lines       18906    18914       +8     
==========================================
+ Hits        17547    17557      +10     
+ Misses       1359     1357       -2

Impacted Files	Coverage Δ
...ta_db/metadata_template/test/test_prep_template.py	99.81% <ø> (-0.01%)	⬇️
..._db/metadata_template/test/test_sample_template.py	99.84% <100%> (-0.01%)	⬇️
...ita_db/metadata_template/base_metadata_template.py	95.17% <100%> (+0.11%)	⬆️
...t/handlers/api_proxy/tests/test_sample_template.py	98.66% <0%> (+0.88%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a369cad...d1bbe46. Read the comment docs.

[tanaes]

Is there a reason to do this way instead of current_map = current_map.loc[md_template.index, md_template.columns]?

[josenavas]

I don't think so. I know that sometimes one option is creating a view while the other one returning an actual pandas DataFrame object, and that can raise Warning in some operations. I don't think it actually matters here, but I wanted to minimize code modifications (I'm actually just moving code around in this PR to be able to reuse code easily).

[wasade]

👍

[josenavas]

Thanks @wasade / @tanaes - able to merge? (I don't want to do a self high-five 😄 )

[tanaes]

I approved, just had the question for learning purposes. Not sure @wasade has finished review? Can merge if so.

…

On Mon, Aug 21, 2017 at 11:49 AM Jose Navas ***@***.***> wrote: Thanks @wasade <https://github.com/wasade> / @tanaes <https://github.com/tanaes> - able to merge? (I don't want to do a self high-five 😄 ) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2247 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH6JAC7aeY4R4ymLuiL8ATvoYmvpSPlJks5sadE4gaJpZM4O9iPp> .

[josenavas]

No problem @tanaes - Yes, @wasade gave the 👍 so you can merge. Thanks!